-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(files): encrypted bucket for personal files #1790
Conversation
βοΈ Yeeeehaw, deploy preview is ready! π¨ Explore the source changes: eba668e π Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/622a24eee75b9f0008d6da9b π Browse the preview: https://deploy-preview-1790--adoring-edison-dbcef8.netlify.app |
@josephmcg Can you generate thumnails, and only pull/decrypt those on a per folder basis so the slow feeling for the user is reduced as much as possible, and don't decrypt any full size files until the user goes to download, or, in the future, share them? |
@WanderingHogan Also a good idea. I'll play around with it today |
Thanks Phill, I made a mistake on my guard clause, so svg and heic were both broken. should be better now I've had issues with that svg in particular as well. I think there's some sort of encoding issue in the header. I adjusted a line in the file then in started working. shared updated version below. it needed |
at the moment, we're only supporting the embeddable image types as well as heic since everyone and their mother has an iphone. We could certainly look into adding a thumbnail for videos, maybe even pdfs in a different ticket |
Hi Joe! I tested again and found something kinda strange, so I uploaded a AVIF and the thumbnail/preview was a still picture, I think uploaded the same file to Dev.Satellite.one and the thumbnail and preview were both animated local.to.dev.satellite.mov |
good catch, that seems like a minor issue we could address in a separate ticket. I'd love to get this merged so I can work on additional features. In the preview, we're no longer accessing the original file. I stored a thumbnail of the image as a base64 string inside the index file. In order to view encrypted files, you would need to pull them down first - slowing performance a bit. Currently, it will only download the full file if you click and check the full screen view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job Joe, nice to see this stuff coming together
π΄ Breaking change - need to open a new account or files won't be encrypted
What this PR does π
Which issue(s) this PR fixes π¨
AP-984, AP-955, AP-970
Special notes for reviewers ποΈ
Additional comments π€